feat: primitive utils and improvements #52
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prestwich
reviewed
May 21, 2023
| derive_more = "0.99" | ||
| tiny-keccak = { workspace = true, features = ["keccak"] } | ||
| bytes.workspace = true | ||
| getrandom = "0.2" |
There was a problem hiding this comment.
This? https://docs.rs/getrandom/latest/getrandom/#webassembly-support
This feature should only be enabled for binary, test, or benchmark crates. Library crates should generally not enable this feature, leaving such a decision to users of their library. Also, libraries should not introduce their own js features just to enable getrandom’s js feature.
There was a problem hiding this comment.
okay only change I want here is documentation that wasm users must set this feature in either their dev-deps or their main deps
that can be in a separate PR
prestwich
reviewed
May 30, 2023
prestwich
reviewed
May 30, 2023
Merged
|
needs the doc fixed |
prestwich
reviewed
May 31, 2023
| } | ||
| } | ||
|
|
||
| /// See Section 4.3.1 "Transaction Receipt" of the Ethereum Yellow Paper. |
prestwich
requested changes
May 31, 2023
* refactor: improve bloom implementation quality * chore: fmt * fixes: address PR review comments
prestwich
approved these changes
May 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-picked from #48, #50 and #51. Necessary for #51.
Supersedes #48