chore: use workspace.{package,dependencies} #17
Conversation
There was a problem hiding this comment.
Let's not do cfg(any(test, feature)), so tests run only when the feature is enabled, instead of always.
| @@ -504,6 +504,7 @@ impl<const BITS: usize, const LIMBS: usize> serde::Serialize for Signed<BITS, LI | |||
| } | |||
| } | |||
|
|
|||
| #[cfg(feature = "serde")] | |||
There was a problem hiding this comment.
This was missing and failing individual compilation (with -p), tho I'm not sure why this cannot be caught when compiling the workspace.
| @@ -514,20 +515,18 @@ impl<'de, const BITS: usize, const LIMBS: usize> serde::Deserialize<'de> for Sig | |||
| } | |||
| } | |||
|
|
|||
| #[cfg(test)] | |||
| #[cfg(all(test, feature = "std"))] | |||
There was a problem hiding this comment.
Use of String, ToString.
| #[auto_impl(&)] | ||
| #[cfg_attr(feature = "alloc", auto_impl(Box, Arc))] |
There was a problem hiding this comment.
Drop auto_impl for manual impl :^)
| } | ||
| } | ||
|
|
||
| impl Encodable for [u8] { |
There was a problem hiding this comment.
All methods take &self so this has to be implemented without the ref.
| # TODO: Can we remove std from here? | ||
| eip712-serde = ["std", "dep:serde"] |
There was a problem hiding this comment.
util::StringifiedNumeric uses String and ToString
There was a problem hiding this comment.
we could remove std by importing String and ToString from alloc 🤔
| @@ -142,7 +145,7 @@ impl<'de> serde::Deserialize<'de> for B512 { | |||
| } | |||
| } | |||
|
|
|||
| // code optained from: https://docs.rs/impl-serde/0.4.0/impl_serde/ | |||
| // code stolen from: https://docs.rs/impl-serde/0.4.0/impl_serde/ | |||
Fixes #13
Use valid
package.categoriesin manifests: https://crates.io/category_slugsPass on
stdfeature to dependencies everywhereRemoves "profile.dev" optimizations, results in way faster compilation:
CC @prestwich