Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: issue and PR templates #33 #93

Merged
merged 7 commits into from
Jun 12, 2023
Merged

feat: issue and PR templates #33 #93

merged 7 commits into from
Jun 12, 2023

Conversation

prestwich
Copy link
Member

Closes #33

@prestwich prestwich added the enhancement New feature or request label Jun 10, 2023
@prestwich prestwich self-assigned this Jun 10, 2023
Copy link
Member

@DaniPopes DaniPopes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we modernize these with like a form? I really dislike having plaintext instructions

this information is using `cargo-tree`.

`cargo install cargo-tree`
(see install here: https://github.com/sfackler/cargo-tree)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cargo-tree has been integrated directly into Cargo as of the 1.44.0 release. This repository is archived as a result.

@prestwich
Copy link
Member Author

agreed. I just copied these over from ethers as a placeholder. will put in some extra effort

Copy link
Member

@DaniPopes DaniPopes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can open the file on github to get it parsed and view end result, and there's a parse issue: https://github.com/alloy-rs/core/blob/89c80f5e1338e6bb3546879c6fbbf3773298c0dd/.github/ISSUE_TEMPLATE/BUG-FORM.yml

.github/ISSUE_TEMPLATE/BUG-FORM.yml Outdated Show resolved Hide resolved
.github/ISSUE_TEMPLATE/FEATURE-FORM.yml Outdated Show resolved Hide resolved
.github/ISSUE_TEMPLATE/FEATURE-FORM.yml Outdated Show resolved Hide resolved
.github/ISSUE_TEMPLATE/BUG-FORM.yml Outdated Show resolved Hide resolved
.github/ISSUE_TEMPLATE/BUG-FORM.yml Outdated Show resolved Hide resolved
@prestwich prestwich enabled auto-merge (squash) June 12, 2023 19:29
@prestwich prestwich merged commit dd969b0 into main Jun 12, 2023
@DaniPopes DaniPopes deleted the prestwich/templates branch June 12, 2023 19:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Issue and PR templates
2 participants