feat(rpc-types-anvil): add Index, fix compatibility
#931
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zerosnacks
requested review from
DaniPopes,
gakonst,
mattsse,
onbjerg,
prestwich and
Evalir
as code owners
|
Moved back to draft as some more compatibility fixes may be required |
zerosnacks
force-pushed
the
zerosnacks/enhance-anvil-types
branch
from
0502553 to
767cd22
Compare
DaniPopes
requested changes
Jun 18, 2024
zerosnacks
changed the title
IndexIndex, fix compatibility
|
Compatibility fixes have been applied, see passing CI: https://github.com/foundry-rs/foundry/actions/runs/9564223504 |
mattsse
approved these changes
Jun 18, 2024
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
DaniPopes
approved these changes
Jun 18, 2024
ben186
pushed a commit
to ben186/alloy
that referenced
this pull request
Jul 27, 2024
* add Index * add test * fix clippy warning * improve serialization test * prefer in-line de::Error * prefer name vs generic deserialized * mark as untagged, handle block serialization * attempt at more compatibility fixes * add test cases with intended use * switch back to quantity::opt, do not tag blocks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Closes: #838
Required for: foundry-rs/foundry#8084
Related PR in Foundry: foundry-rs/foundry#8186
Solution
Adds
Index, previously missing from therpc-types-anvilFixes deserialization issue in
MineOptionsAlso added some tests for
Forking,IndexandMineOptionsserialization as this was giving trouble in FoundryPR Checklist