Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix remaining warnings, add TODO for proptest-derive #819

Merged
merged 1 commit into from
Jun 3, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions crates/consensus/src/request.rs
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
#![allow(unknown_lints, non_local_definitions)] // TODO: remove when proptest-derive updates

use alloy_eips::{
eip6110::DepositRequest,
eip7002::WithdrawalRequest,
Expand Down
2 changes: 1 addition & 1 deletion crates/eips/src/eip1898.rs
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
//! [EIP-1898]: https://eips.ethereum.org/EIPS/eip-1898

#![allow(unknown_lints, non_local_definitions)]
#![allow(unknown_lints, non_local_definitions)] // TODO: remove when proptest-derive updates

use alloy_primitives::{hex::FromHexError, ruint::ParseError, BlockHash, BlockNumber, B256, U64};
use alloy_rlp::{bytes, Decodable, Encodable, Error as RlpError};
Expand Down
2 changes: 2 additions & 0 deletions crates/eips/src/eip2930.rs
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,8 @@
//!
//! [EIP-2930]: https://eips.ethereum.org/EIPS/eip-2930

#![allow(unknown_lints, non_local_definitions)] // TODO: remove when proptest-derive updates

#[cfg(not(feature = "std"))]
use alloc::vec::Vec;

Expand Down
2 changes: 2 additions & 0 deletions crates/eips/src/eip4844/sidecar.rs
Original file line number Diff line number Diff line change
@@ -1,5 +1,7 @@
//! EIP-4844 sidecar type

#![allow(unknown_lints, non_local_definitions)] // TODO: remove when proptest-derive updates

use crate::eip4844::{
kzg_to_versioned_hash, Blob, Bytes48, BYTES_PER_BLOB, BYTES_PER_COMMITMENT, BYTES_PER_PROOF,
};
Expand Down
2 changes: 2 additions & 0 deletions crates/eips/src/eip4895.rs
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,8 @@
//!
//! [EIP-4895]: https://eips.ethereum.org/EIPS/eip-4895

#![allow(unknown_lints, non_local_definitions)] // TODO: remove when proptest-derive updates

use alloy_primitives::{Address, U256};
use alloy_rlp::{RlpDecodable, RlpEncodable};

Expand Down
2 changes: 2 additions & 0 deletions crates/eips/src/eip6110.rs
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,8 @@
//!
//! Provides validator deposits as a list of deposit operations added to the Execution Layer block.

#![allow(unknown_lints, non_local_definitions)] // TODO: remove when proptest-derive updates

use alloy_primitives::{address, Address, FixedBytes, B256};
use alloy_rlp::{RlpDecodable, RlpEncodable};

Expand Down
2 changes: 1 addition & 1 deletion crates/eips/src/eip7002.rs
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
//!
//! See also [EIP-7002](https://eips.ethereum.org/EIPS/eip-7002): Execution layer triggerable withdrawals

#![allow(unknown_lints, non_local_definitions)]
#![allow(unknown_lints, non_local_definitions)] // TODO: remove when proptest-derive updates

use alloy_primitives::{address, bytes, Address, Bytes, FixedBytes};
use alloy_rlp::{RlpDecodable, RlpEncodable};
Expand Down
5 changes: 3 additions & 2 deletions crates/provider/src/provider/trait.rs
Original file line number Diff line number Diff line change
Expand Up @@ -944,11 +944,9 @@ impl<T: Transport + Clone, N: Network> Provider<T, N> for RootProvider<T, N> {
mod tests {
use super::*;
use crate::{ProviderBuilder, WalletProvider};
use alloy_network::TransactionBuilder;
use alloy_node_bindings::Anvil;
use alloy_primitives::{address, b256, bytes};
use alloy_rpc_types::request::TransactionRequest;
use alloy_sol_types::SolValue;

fn init_tracing() {
let _ = tracing_subscriber::fmt::try_init();
Expand Down Expand Up @@ -1370,6 +1368,9 @@ mod tests {
feature = "reqwest-native-tls",
))]
async fn call_mainnet() {
use alloy_network::TransactionBuilder;
use alloy_sol_types::SolValue;

init_tracing();
let url = "https://eth-mainnet.alchemyapi.io/v2/jGiK5vwDfC3F4r0bqukm-W2GqgdrxdSr";
let provider = ProviderBuilder::new().on_http(url.parse().unwrap());
Expand Down
2 changes: 2 additions & 0 deletions crates/rpc-types/src/eth/log.rs
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
#![allow(unknown_lints, non_local_definitions)] // TODO: remove when proptest-derive updates

use alloy_primitives::{LogData, B256};
use serde::{Deserialize, Serialize};

Expand Down
2 changes: 2 additions & 0 deletions crates/rpc-types/src/eth/transaction/receipt.rs
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
#![allow(unknown_lints, non_local_definitions)] // TODO: remove when proptest-derive updates

use crate::{Log, WithOtherFields};
use alloy_consensus::{AnyReceiptEnvelope, ReceiptEnvelope, TxType};
use alloy_primitives::{Address, B256};
Expand Down
Loading