debug_trace_block_ fix #723
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dexloom
requested review from
DaniPopes,
gakonst,
mattsse,
onbjerg,
prestwich and
Evalir
as code owners
added 2 commits
May 11, 2024 11:37
|
getting this in in #730 can't push manual changes to main branch |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Improperly described return types for debug_block_* functions and improperly encoded block number parameter for debug_block_by_number
Solution
debug_trace_block_by_number block parameter changed to BlockNumberOrTag for proper serialization
debug_trace_block_by_number and debug_trace_block_by_hash return type changed to Vec<TraceResult>
PR Checklist
Added Tests
Added Documentation
Breaking changes
Fix for this issue : #657