From cbcedb8f1c7d8476837635a11980958486816f75 Mon Sep 17 00:00:00 2001 From: Abner Zheng Date: Fri, 12 Apr 2024 23:32:33 +0800 Subject: [PATCH] update comments --- crates/rpc-types/src/eth/transaction/error.rs | 2 +- crates/rpc-types/src/eth/transaction/mod.rs | 5 +++-- 2 files changed, 4 insertions(+), 3 deletions(-) diff --git a/crates/rpc-types/src/eth/transaction/error.rs b/crates/rpc-types/src/eth/transaction/error.rs index 9480e311483..388434b40d8 100644 --- a/crates/rpc-types/src/eth/transaction/error.rs +++ b/crates/rpc-types/src/eth/transaction/error.rs @@ -34,7 +34,7 @@ pub enum ConversionError { /// Missing `to` field for EIP-4844 transaction. #[error("missing `to` field for EIP-4844 transaction")] MissingTo, - /// Missing `chainId` field for EIP-1559 transaction. + /// Missing `blobVersionedHashes` field for EIP-4844 transaction. #[error("missing `blobVersionedHashes` field for EIP-4844 transaction")] MissingBlobVersionedHashes, } diff --git a/crates/rpc-types/src/eth/transaction/mod.rs b/crates/rpc-types/src/eth/transaction/mod.rs index 021e05e81ec..1a6545c8ada 100644 --- a/crates/rpc-types/src/eth/transaction/mod.rs +++ b/crates/rpc-types/src/eth/transaction/mod.rs @@ -105,8 +105,9 @@ pub struct Transaction { pub access_list: Option, /// EIP2718 /// - /// Transaction type, Some(2) for EIP-1559 transaction, - /// Some(1) for AccessList transaction, None for Legacy + /// Transaction type, + /// Some(3) for EIP-4844 transaction, Some(2) for EIP-1559 transaction, + /// Some(1) for AccessList transaction, None or Some(0) for Legacy #[serde( default, rename = "type",