feat(rpc-types): RLP encoding/decoding for transaction types
#36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Evalir
requested review from
DaniPopes,
gakonst and
prestwich
as code owners
prestwich
reviewed
Nov 20, 2023
Evalir
merged commit 81bd5de
into
onbjerg/alloy-temp-provider-trait
15 of 16 checks passed
onbjerg
pushed a commit
that referenced
this pull request
Nov 25, 2023
gakonst
pushed a commit
that referenced
this pull request
Dec 18, 2023
* wip * chore: docs * feat: add `get_block` * fmt * fix rebase * more fix * fmt * more rebase fix * more fix * fmt * rm unused crates * more fix * async trait wasm awesome hack * ? * ?? * ?????????? * hokus pokus * feat: add tracing methods and a couple other ones (#32) * chore: TransactionRequest -> CallRequest (#33) * fix: return U256 for estimate_gas (#35) * fix: serialize block num w/o leading zeros (#37) * fix: use u64 for block numbers (#38) * fix: serialize block num w/o leading zeros * fix: use `u64` for block numbers * fix: deserialize block num as U64 (#39) * fix: typo * fix: dont skip gas used ratio if empty (#40) * workaround * fix: actual fix * fix: actual fix part 2 * fix(rpc-types): access list keys (#42) * workaround * fix: actual fix * fix: actual fix part 2 * fix access list keys --------- Co-authored-by: Enrique Ortiz <[email protected]> * chore: remove Cow from `TempProvider` (#43) * chore: start removing cows * chore: uncow tempProvider * Apply suggestions from code review Co-authored-by: DaniPopes <[email protected]> * switch to single element tuple --------- Co-authored-by: DaniPopes <[email protected]> * feat(`rpc-types`): RLP encoding/decoding for transaction types (#36) * feat: add rlp encoding/decoding to tx types * feat: add encodable/decodable traits to tx * chore: remove out-of-scope func * chore: remove bad links on comments * chore: fix docs * clippy * feat(`TempProvider`): `raw_request` (#45) * feat(): raw_request * chore: remove unneeded async block * chore: bump alloy-primitives * chore: set uncle as default when missing transactions field * fmt * chore: remove pub * feat: support for additional fields on TransactionReceipt and Block (#66) * chore: add support for OtherFields in Transaction (#68) * chore: turn off reqwest default features * chore: address provider review comments (#87) * chore: remove self: sync from defs * chore: remove most generics * chore: default for BlockId * chore: remove unnecesary reassignment * chore: auto impl on mut/rc * chore: unnecesary assignment --------- Co-authored-by: Enrique Ortiz <[email protected]> Co-authored-by: DaniPopes <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
We need RLP encoding and decoding in the transaction related types.
Solution
Add them. Follows
reth-primitives's and foundry's anvil rlp implementation as closely as possible, using alloy rlp.PR Checklist