Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: trace_call and trace_callMany #277

Merged
merged 3 commits into from
Mar 12, 2024
Merged

feat: trace_call and trace_callMany #277

merged 3 commits into from
Mar 12, 2024

Conversation

onbjerg
Copy link
Member

@onbjerg onbjerg commented Mar 12, 2024

Motivation

Closes #225

Solution

Adds the methods

Unsure how to test this given this is unsupported by Anvil

PR Checklist

  • Added Tests
  • Added Documentation
  • Breaking changes

@onbjerg onbjerg added the enhancement New feature or request label Mar 12, 2024
Copy link
Member

@DaniPopes DaniPopes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm pending easy conflicts

async fn trace_call(
&self,
request: &N::TransactionRequest,
trace_type: Vec<TraceType>,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Slice perhaps? &[TraceType]

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes perchance

@onbjerg onbjerg merged commit b7eb33d into main Mar 12, 2024
15 checks passed
@onbjerg onbjerg deleted the onbjerg/trace branch March 12, 2024 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature] trace_call / trace_call_many
2 participants