chore(rpc): rename witness fields #1293
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rkrasiuk
requested review from
DaniPopes,
gakonst,
mattsse,
onbjerg,
prestwich and
emhane
as code owners
0x00101010
reviewed
Sep 16, 2024
| pub state_preimages: Option<HashMap<B256, Bytes>>, | ||
| /// keccak(rlp(node)) => rlp(node) | ||
| pub state: HashMap<B256, Bytes>, | ||
| /// Map of all hashed account and storage keys (addresses and slots) to their preimages |
There was a problem hiding this comment.
Can we add codes here as well? 🙏 It will be needed per our discussion in the thread
There was a problem hiding this comment.
There was a problem hiding this comment.
we can add those separately once we resolve some questions regarding compatibility
mattsse
approved these changes
Sep 17, 2024
lwedge99
pushed a commit
to sentioxyz/alloy
that referenced
this pull request
Oct 8, 2024
* chore(rpc): rename witness fields * chore: allow missing keys --------- Co-authored-by: Matthias Seitz <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Rename witness fields and amend docs to clarify what they represent.