Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: move mev.rs from reth to rpc-types-mev #970

Merged
merged 11 commits into from Jun 25, 2024
Merged

feat: move mev.rs from reth to rpc-types-mev #970

merged 11 commits into from Jun 25, 2024

Conversation

ghost
Copy link

@ghost ghost commented Jun 25, 2024

@ghost ghost changed the title feat: move mev.rs from alloy to rpc-types-mev feat: move mev.rs from reth to rpc-types-mev Jun 25, 2024
@ghost ghost marked this pull request as draft June 25, 2024 11:40
mattsse
mattsse requested changes Jun 25, 2024
View reviewed changes
Copy link
Member

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ty, some early comments

we also want a feature in rpc-types for this

crates/rpc-types-mev/Cargo.toml Outdated Show resolved Hide resolved
@mattsse mattsse marked this pull request as ready for review June 25, 2024 13:43
mattsse
mattsse requested changes Jun 25, 2024
View reviewed changes
Copy link
Member

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd like to not have a ton of modules just for single types

I'm fine with separating eth and mev modules

@ghost
Copy link
Author

ghost commented Jun 25, 2024 •
edited by ghost
Loading

yeah, it's reasonable, I tried to split it by endpoint but it seems to be a bit much in the end.

mattsse
mattsse approved these changes Jun 25, 2024
View reviewed changes
Copy link
Member

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mattsse mattsse added the enhancement New feature or request label Jun 25, 2024
@mattsse mattsse merged commit 46d93cd into alloy-rs:main Jun 25, 2024
22 checks passed
@zerosnacks zerosnacks mentioned this pull request Jun 25, 2024
Closed
@ghost ghost deleted the introduce-rpc-types-mev branch June 25, 2024 17:25
ben186 pushed a commit to ben186/alloy that referenced this pull request Jul 27, 2024
feat: move mev.rs from reth to rpc-types-mev (alloy-rs#970)
45a9c1f 
* feat: move mev.rs from alloy to rpc-types-mev

* fmt

* doc: update README

* feature rpc-types-mev

* dev: use alloy_serde directly

* dev: split to bundle_stats and u256_numeric_string

* dev(refactor): split to multiple files based on endpoint

* dev: add mev as features and re export in lib

* fmt

* dev: simplify

* dev: merge to eth_calls, mev_calls and stats
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DaniPopes DaniPopes Awaiting requested review from DaniPopes DaniPopes is a code owner

@gakonst gakonst Awaiting requested review from gakonst gakonst is a code owner

@onbjerg onbjerg Awaiting requested review from onbjerg onbjerg is a code owner

@prestwich prestwich Awaiting requested review from prestwich

@Evalir Evalir Awaiting requested review from Evalir

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@mattsse