Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: remove proptest in all crates and Arbitrary derives #966

Merged
merged 6 commits into from
Jul 11, 2024
Merged

chore: remove proptest in all crates and Arbitrary derives #966

merged 6 commits into from
Jul 11, 2024

Conversation

Rjected
Copy link
Contributor

@Rjected Rjected commented Jun 24, 2024 •
edited
Loading

Motivation

This was only required because reth required these types to implement proptest::Arbitrary. This is no longer the case, and arbitrary::Arbitrary is already usable.

Solution

Remove almost all proptest derives, remove unused proptest dependencies.

There is a single proptest! left, which is for other fields, would like to know whether that's necessary or not.

PR Checklist

  • Added Tests
  • Added Documentation
  • Breaking changes

DaniPopes
DaniPopes approved these changes Jun 24, 2024
View reviewed changes
Copy link
Member

@DaniPopes DaniPopes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

which derives are missing?

@Rjected
Copy link
Contributor Author

Rjected commented Jun 24, 2024

which derives are missing?

just this:

alloy/crates/serde/src/other/mod.rs

Line 175 in c2dd7ce

derive(proptest_derive::Arbitrary, arbitrary::Arbitrary)

used for this:

alloy/crates/serde/src/other/arbitrary_.rs

Line 91 in c2dd7ce

proptest::proptest!(

@DaniPopes
Copy link
Member

DaniPopes commented Jun 24, 2024 •
edited
Loading

Ah yeah the custom impl and test can be removed, it's only there because proptest derive doesn't support recursion

@Rjected Rjected changed the title chore: remove proptest in most crates and Arbitrary derives chore: remove proptest in all crates and Arbitrary derives Jun 25, 2024
@Rjected Rjected force-pushed the dan/remove-proptest-derives branch from e8ef353 to 4ba7d70 Compare July 11, 2024 20:19
@mattsse mattsse merged commit d9d9262 into alloy-rs:main Jul 11, 2024
1 check passed
ben186 pushed a commit to ben186/alloy that referenced this pull request Jul 27, 2024
@Rjected
chore: remove proptest in all crates and Arbitrary derives (alloy-rs#966
1b4bf03 
)

* chore: remove proptest in most crates and Arbitrary derives

* cargo fmt

rewriting static

* remove other proptest derive

* remove the rest of the proptest impls

* make arbitraryvalue not pub

* remove proptest derive from auth list
j75689 pushed a commit to bnb-chain/alloy that referenced this pull request Aug 1, 2024
@Rjected @j75689
chore: remove proptest in all crates and Arbitrary derives (alloy-rs#966
7bff14c 
)

* chore: remove proptest in most crates and Arbitrary derives

* cargo fmt

rewriting static

* remove other proptest derive

* remove the rest of the proptest impls

* make arbitraryvalue not pub

* remove proptest derive from auth list
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DaniPopes DaniPopes DaniPopes approved these changes

@mattsse mattsse mattsse approved these changes

@gakonst gakonst Awaiting requested review from gakonst gakonst is a code owner

@onbjerg onbjerg Awaiting requested review from onbjerg onbjerg is a code owner

@prestwich prestwich Awaiting requested review from prestwich

@Evalir Evalir Awaiting requested review from Evalir

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Rjected @DaniPopes @mattsse