feat(rpc): Split off eth namespace in alloy-rpc-types to alloy-rpc-types-eth
#847
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattsse
reviewed
Jun 7, 2024
zerosnacks
requested review from
DaniPopes,
gakonst,
onbjerg,
prestwich and
Evalir
as code owners
zerosnacks
commented
Jun 7, 2024
mattsse
reviewed
Jun 7, 2024
|
needs rebase onto main then g2g i think |
ben186
pushed a commit
to ben186/alloy
that referenced
this pull request
Jul 27, 2024
…pc-types-eth` (alloy-rs#847) * start with eth namespace split * continue * move with_other to rpc-types * add back WithOtherFields into `rpc-types-eth` due to circular dependency in request / receipt * avoid defaulting features in meta-crate * re-add feature flags * use metacrate * add rpc-types-eth as enabled flag as default-features are disabled in alloy metacrate * export as * * trim rpc-types- prefix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Closes #198
Solution
alloy-rpc-typesinto a metacrate linking the individual type cratesethnamespace inalloy-rpc-typestoalloy-rpc-types-ethGiven that
alloy/crates/rpc-types-eth/src/transaction/request.rs
Line 803 in 31054e2
alloy/crates/rpc-types-eth/src/transaction/receipt.rs
Line 3 in 31054e2
WithOtherFieldsmoving this to thealloy-rpc-typesmetacrate creates a circular dependency. Therefore I've included it in thealloy-rpc-types-ethcrate for now. If we do want to move it tocoreI'm not sure where we should put it.Given that there are some open questions: #198 (comment) I think it is best to see this as a draft - open to feedback
Tested against
alloy/examples, no changes required therePR Checklist