Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] Mark Eip2718Error as non_exhaustive #837

Merged
merged 1 commit into from
Jun 6, 2024

Conversation

prestwich
Copy link
Member

Closes #826

PR Checklist

  • Added Tests
  • Added Documentation
  • Breaking changes

@prestwich prestwich added the debt Tech debt which needs to be addressed label Jun 6, 2024
@prestwich prestwich self-assigned this Jun 6, 2024
@prestwich prestwich changed the title Prestwich/non exhaustive 2718 [Fix] Mark Eip2718Error as non_exhaustive Jun 6, 2024
@prestwich prestwich force-pushed the prestwich/non-exhaustive-2718 branch from 9a5ac7e to e9542ab Compare June 6, 2024 15:35
@prestwich prestwich merged commit 0c97786 into main Jun 6, 2024
24 checks passed
@prestwich prestwich deleted the prestwich/non-exhaustive-2718 branch June 6, 2024 15:46
ben186 pushed a commit to ben186/alloy that referenced this pull request Jul 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
debt Tech debt which needs to be addressed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Eip2718Error should be #[non_exhaustive] to allow future encoding errors
2 participants