Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug(upstream): pin gcloud-sdk to 0.24.6 #836

Merged
merged 1 commit into from
Jun 6, 2024
Merged

Bug(upstream): pin gcloud-sdk to 0.24.6 #836

merged 1 commit into from
Jun 6, 2024

Conversation

zerosnacks
Copy link
Member

@zerosnacks zerosnacks commented Jun 6, 2024 •
edited
Loading

Motivation

0.24.7 released in the last hour throws a deep build issue that is breaking the CI

error[E0412]: cannot find type `Operation` in module `super::super::super::super::longrunning`
    --> /home/zerosnacks/.cargo/registry/src/index.crates.io-6f17d22bba15001f/gcloud-sdk-0.24.7/src/../genproto/google.cloud.kms.v1.rs:1432:70
     |
1432 |             tonic::Response<super::super::super::super::longrunning::Operation>,
     |                                                                      ^^^^^^^^^ not found in `super::super::super::super::longrunning`

For more information about this error, try `rustc --explain E0412`.

Solution

Pin to =0.24.6

PR Checklist

  • Added Tests
  • Added Documentation
  • Breaking changes

@zerosnacks
Copy link
Member Author

zerosnacks commented Jun 6, 2024 •
edited
Loading

Link to bug report: abdolence/gcloud-sdk-rs#144

@zerosnacks zerosnacks merged commit 38cdb7c into main Jun 6, 2024
24 checks passed
@zerosnacks zerosnacks deleted the zerosnacks/pin-gcloud-sdk-to-0.24.6 branch June 6, 2024 15:29
@zerosnacks zerosnacks mentioned this pull request Jun 6, 2024
Merged
3 tasks
ben186 pushed a commit to ben186/alloy that referenced this pull request Jul 27, 2024
@zerosnacks
pin to 0.24.6 (alloy-rs#836)
6dcc69d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@prestwich prestwich prestwich approved these changes

@DaniPopes DaniPopes Awaiting requested review from DaniPopes DaniPopes is a code owner

@gakonst gakonst Awaiting requested review from gakonst gakonst is a code owner

@mattsse mattsse Awaiting requested review from mattsse mattsse is a code owner

@onbjerg onbjerg Awaiting requested review from onbjerg onbjerg is a code owner

@Evalir Evalir Awaiting requested review from Evalir

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zerosnacks @prestwich