[Feature] Implement Filter's builder methods on alloy_contract::Event

[StackOverflowExcept1on]

Component

contract

Describe the feature you would like

It would be nice to have method like event_filter_with_address::<Event>(address: impl Into<ValueOrArray<Address>>). For example, you want to subscribe to all DEXs like uniswap.

/// Event filters.
#[automatically_derived]
impl<
    T: alloy_contract::private::Transport + ::core::clone::Clone,
    P: alloy_contract::private::Provider<T, N>,
    N: alloy_contract::private::Network,
> RouterInstance<T, P, N> {
    /// Creates a new event filter using this contract instance's provider and address.
    ///
    /// Note that the type can be any event, not just those defined in this contract.
    /// Prefer using the other methods for building type-safe event filters.
    pub fn event_filter<E: alloy_sol_types::SolEvent>(
        &self,
    ) -> alloy_contract::Event<T, &P, E, N> {
        alloy_contract::Event::new_sol(&self.provider, &self.address)
    }
    ///Creates a new event filter for the [`CreateProgram`] event.
    pub fn CreateProgram_filter(
        &self,
    ) -> alloy_contract::Event<T, &P, CreateProgram, N> {
        self.event_filter::<CreateProgram>()
    }
}

alloy/crates/contract/src/event.rs

Lines 32 to 45 in c6c91cc

	#[doc(hidden)]
	impl<'a, T: Transport + Clone, P: Provider<T, N>, E: SolEvent, N: Network> Event<T, &'a P, E, N> {
	// `sol!` macro constructor, see `#[sol(rpc)]`. Not public API.
	// NOTE: please avoid changing this function due to its use in the `sol!` macro.
	pub fn new_sol(provider: &'a P, address: &Address) -> Self {
	// keccak256 hash of the event signature needed for the filter to actually filter by event
	// check that the event is not anonymous to include the event signature in the filter
	if E::ANONYMOUS {
	Self::new(provider, Filter::new().address(*address))
	} else {
	Self::new(provider, Filter::new().address(*address).event_signature(E::SIGNATURE_HASH))
	}
	}
	}

Additional context

No response

[DaniPopes]

the internal filter can be modified with .filter.address = ...

[StackOverflowExcept1on]

I see, but you need unnecessary mutability

[prestwich]

migrated this, as contract codegen is performed in core.

I am not convinced that we actually want an constructor _with_whatever here instead of a builder-style method. Builders are our typical idiom

[DaniPopes]

In that case if we want to do this it should be builder methods on alloy contract event that just delegate to the underlying filter?

[prestwich]

that sounds right to me