feat(rpc-types): add topic0 (alias event_signature) getter to Log
#799
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…gnatures against it
|
2 things
|
Thanks! Good catch |
zerosnacks
requested review from
DaniPopes,
gakonst,
mattsse,
onbjerg,
prestwich and
Evalir
as code owners
|
one more nit and then lfg we could add a doc alias for event_signature so it shows up in searches |
zerosnacks
changed the title
event_signature (topic0) getter to Logevent_signature) getter to Log
zerosnacks
changed the title
event_signature) getter to Logevent_signature) getter to Log
prestwich
approved these changes
May 29, 2024
ben186
pushed a commit
to ben186/alloy
that referenced
this pull request
Jul 27, 2024
…alloy-rs#799) * add simple getter for the topic0 field, useful when matching event signatures against it * make sure index is safely accessed * fix clippy * add docs alias of event_signature for topic0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Currently there is not an elegant way of accessing the event signature in the
Logas returned by theSubscriptionStream, which is useful for matching against when one subscribes to all (or multiple) contract events.For context: https://github.com/alloy-rs/examples/blob/dbe65d8ca96348ffa64720ea566079e7c1e87fbf/examples/subscriptions/examples/subscribe_all_logs.rs#L45-L62
Solution
Adds simple getter for 0-indexing intotopics, mirrors theevent_signaturesyntax used for settingtopic0on theFilterinstance. I don't see a good reason to add getters for the other topics.Adds simple getter for
topic0, checking for existence.PR Checklist