Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix warnings, check-cfg #776

Merged
merged 1 commit into from
May 24, 2024
Merged

chore: fix warnings, check-cfg #776

merged 1 commit into from
May 24, 2024

Conversation

DaniPopes
Copy link
Member

Fixes #688

Copy link
Member

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

new auto_impls look reasonable to me

@@ -16,6 +17,7 @@ use futures_utils_wasm::impl_future;
/// no specific signer address is specified.
#[cfg_attr(target_arch = "wasm32", async_trait(?Send))]
#[cfg_attr(not(target_arch = "wasm32"), async_trait)]
#[auto_impl(&, &mut, Box, Rc, Arc)]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we want this I think

@DaniPopes DaniPopes merged commit f78a268 into main May 24, 2024
24 checks passed
@DaniPopes DaniPopes deleted the dani/warnings-cfg branch May 24, 2024 18:39
ben186 pushed a commit to ben186/alloy that referenced this pull request Jul 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] Fix --check-cfg warnings
2 participants