Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: include auth token in display #772

Merged
merged 1 commit into from
May 22, 2024
Merged

fix: include auth token in display #772

merged 1 commit into from
May 22, 2024

Conversation

mattsse
Copy link
Member

@mattsse mattsse commented May 22, 2024

closes #771

include the auth token in the display impl

Copy link
Contributor

@Rjected Rjected left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mattsse
Copy link
Member Author

mattsse commented May 22, 2024

reasonable to leak on display, imo
the hyper types also do this and we also leak on debug

@mattsse mattsse merged commit 975b849 into main May 22, 2024
24 checks passed
@mattsse mattsse deleted the matt/fix-auth branch May 22, 2024 20:40
ben186 pushed a commit to ben186/alloy that referenced this pull request Jul 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] Ws auth headers are broken
2 participants