feat: set poll interval based on connected chain #767
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RexCloud
requested review from
DaniPopes,
gakonst,
mattsse,
onbjerg,
prestwich and
Evalir
as code owners
mattsse
requested changes
May 21, 2024
mattsse
reviewed
May 21, 2024
prestwich
requested changes
May 22, 2024
There was a problem hiding this comment.
Approach is a hard NACK from me
- Behavior is non-obvious. Users would not expect that calling an RPC method would change provider behavior
- Not all users will call
get_chain_id, leading to different behavior in a hard-to-diagnose setting - The same program may not call
get_chain_idon different runs, leading to inconsistent configuration for the same code
This could be done idiomatically by adding ProviderBuilder methods to provide or fetch this at instantiation time
fn with_chain()
async fn fetch_chain()
prestwich
requested changes
May 23, 2024
prestwich
approved these changes
May 24, 2024
ben186
pushed a commit
to ben186/alloy
that referenced
this pull request
Jul 27, 2024
* feat: set poll interval based on connected chain * Revert changes * feat: `ChainLayer` to set poll interval based on chain * use const fn
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Closes #604
Solution
Add
with_chain()method toProviderBuilder. TheChainLayerwill fetch the average block time for the chain and set client's poll intervalPR Checklist