Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: beacon sidecar iterator #718

Merged
merged 4 commits into from
May 10, 2024

Conversation

JackG-eth
Copy link
Contributor

Iterator for new beacon EIP4844 type

Motivation
This will alllow us to grab n blobs for a given tx from the CL

it will also unblock paradigmxyz/reth#7443

Copy link
Member

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

few nits

crates/rpc-types-beacon/src/sidecar.rs Show resolved Hide resolved
crates/rpc-types-beacon/src/sidecar.rs Show resolved Hide resolved
crates/rpc-types-beacon/src/sidecar.rs Show resolved Hide resolved
@JackG-eth JackG-eth requested a review from mattsse May 10, 2024 11:30
Copy link
Member

@yash-atreya yash-atreya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@prestwich prestwich merged commit f7b7f04 into alloy-rs:main May 10, 2024
24 checks passed
ben186 pushed a commit to ben186/alloy that referenced this pull request Jul 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants