feat: add eip-7685 enc/decode traits #704
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
onbjerg
requested review from
DaniPopes,
gakonst,
mattsse,
prestwich and
Evalir
as code owners
3 tasks
mattsse
requested changes
May 7, 2024
There was a problem hiding this comment.
can we add a combined trait for this as well?
alloy/crates/eips/src/eip2718.rs
Lines 189 to 190 in 77c1240
mattsse
approved these changes
May 7, 2024
prestwich
reviewed
May 7, 2024
ben186
pushed a commit
to ben186/alloy
that referenced
this pull request
Jul 27, 2024
* feat: add eip-7685 enc/decode traits * chore: fmt * feat: combined trait * chore: mark non_exhaustive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
EIP-7685 adds an EL → CL request list. The list items are requests, which are encoded as
type ++ request_data, whererequest_datais an opaque byte buffer. The meaning of the bytes is up to each request, which are defined in separate EIPs.Solution
Add traits for encoding and decoding requests. This follows the same overall design as our traits for EIP-2718, with the difference being that EIP-2718 also has special handling for legacy transactions.
The expected usage is to define something a la
TxEnvelope, e.g.RequestsEnvelope, which is an enum that internally holds each legal request type. The requests themselves are decoded and encoded according to their own EIPs, e.g. with RLP.PR Checklist