Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: tracing for http transports #681

Merged
merged 2 commits into from
May 4, 2024
Merged

feat: tracing for http transports #681

merged 2 commits into from
May 4, 2024

Conversation

prestwich
Copy link
Member

Motivation

debugging zenith builder errors, encountered some missing tracing surface area

Solution

  • remove several differences in hyper and reqwest handling
  • add debug and trace level logging of request dispatch and response characteristics

PR Checklist

  • Added Tests
  • Added Documentation
  • Breaking changes

@prestwich prestwich added enhancement New feature or request debt Tech debt which needs to be addressed labels May 4, 2024
@prestwich prestwich self-assigned this May 4, 2024
@prestwich prestwich merged commit 0bb7604 into main May 4, 2024
24 checks passed
@prestwich prestwich deleted the prestwich/http-tracing branch May 4, 2024 14:21
ben186 pushed a commit to ben186/alloy that referenced this pull request Jul 27, 2024
@prestwich
feat: tracing for http transports (alloy-rs#681)
5b79a5f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Evalir Evalir Evalir approved these changes

@mattsse mattsse mattsse approved these changes

@DaniPopes DaniPopes Awaiting requested review from DaniPopes DaniPopes is a code owner

@gakonst gakonst Awaiting requested review from gakonst gakonst is a code owner

@onbjerg onbjerg Awaiting requested review from onbjerg onbjerg is a code owner

Assignees

@prestwich prestwich

Labels
debt Tech debt which needs to be addressed enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@prestwich @mattsse @Evalir