Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Move kzg validation to blobtransaction sidecar #675

Closed
mattsse opened this issue May 3, 2024 · 0 comments · Fixed by #677
Closed

[Feature] Move kzg validation to blobtransaction sidecar #675

mattsse opened this issue May 3, 2024 · 0 comments · Fixed by #677
Labels
enhancement New feature or request

Comments

@mattsse
Copy link
Member

mattsse commented May 3, 2024

Component

consensus, eips, genesis

Describe the feature you would like

currently blob validation is part of the 4844 tx:

pub fn validate_blob(
&self,
sidecar: &BlobTransactionSidecar,
proof_settings: &KzgSettings,
) -> Result<(), BlobTransactionValidationError> {

it would be more useful to have the impl as a function on the sidecar:

pub fn validate(
        &self,
        versioned_hashes: &[B256],
        proof_settings: &KzgSettings,
    ) -> Result<(), BlobTransactionValidationError> {

this way it becomes reusable

the tx4844 impl then simply calls this will its versioned hashes and the given settings.

Additional context

No response

@mattsse mattsse added the enhancement New feature or request label May 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant