RpcWithBlock #674
Merged
RpcWithBlock #674
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prestwich
added
enhancement
prestwich
requested review from
DaniPopes,
gakonst,
mattsse,
onbjerg and
Evalir
as code owners
|
I can't help but feel like the bounds could be simpler |
prestwich
force-pushed
the
prestwich/block-id-rpc
branch
from
9732eca
to
19eb08f
Compare
I was right. they are now simpler. Unpin and Clone bounds are removed |
ben186
pushed a commit
to ben186/alloy
that referenced
this pull request
Jul 27, 2024
* wip: RpcWithBlock * wip * wip * feat: working maps * lint: clippy and simplify * feat: convert get_proof * feat: convert create_access_list * feat: convert trace_call * refactor: finish converting RPC methods * fix: remove unpin bounds * nit: comment * fix: remove clone bounds * nit: reduce nesting
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
followup to #645
closes #613
Solution
Generic builder struct for rpc calls that take optional block id parameters
PR Checklist