Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: use alloy types for BlobTransactionSidecar #673

Merged
merged 5 commits into from
May 3, 2024
Merged

feat: use alloy types for BlobTransactionSidecar #673

merged 5 commits into from
May 3, 2024

Conversation

mattsse
Copy link
Member

@mattsse mattsse commented May 3, 2024

closes #402

  • moved sidecar types to eips crate
  • c-kzg conversion via trasmute, from_raw_parts where required

@onbjerg onbjerg added the debt Tech debt which needs to be addressed label May 3, 2024
onbjerg
onbjerg reviewed May 3, 2024
View reviewed changes
Copy link
Member

@onbjerg onbjerg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

smol nit

crates/eips/src/eip4844/sidecar.rs Outdated Show resolved Hide resolved
@prestwich
Copy link
Member

dope. will review thoroughly when CI is passing

@mattsse mattsse merged commit 44b8a6d into main May 3, 2024
24 checks passed
@mattsse mattsse deleted the matt/move-sidecar-to-eips branch May 3, 2024 19:10
ben186 pushed a commit to ben186/alloy that referenced this pull request Jul 27, 2024
@mattsse @onbjerg
feat: use alloy types for BlobTransactionSidecar (alloy-rs#673)
04b2a8d 
* feat: use alloy types for BlobTransactionSidecar

* type hints

* chore: no-std fix

* Update crates/eips/src/eip4844/sidecar.rs

Co-authored-by: Oliver Nordbjerg <[email protected]>

* use core

---------

Co-authored-by: Oliver Nordbjerg <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@onbjerg onbjerg onbjerg left review comments

@prestwich prestwich prestwich approved these changes

@DaniPopes DaniPopes Awaiting requested review from DaniPopes DaniPopes is a code owner

@gakonst gakonst Awaiting requested review from gakonst gakonst is a code owner

@Evalir Evalir Awaiting requested review from Evalir

Assignees
No one assigned
Labels
debt Tech debt which needs to be addressed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Debt] remove type switching on kzg feature
3 participants
@mattsse @prestwich @onbjerg