Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature] Constrain N::TransactionResponse type to allow access to the hash or other tx details #667

Closed
prestwich opened this issue May 2, 2024 · 2 comments
Closed

[Feature] Constrain N::TransactionResponse type to allow access to the hash or other tx details #667

prestwich opened this issue May 2, 2024 · 2 comments
Assignees
@yash-atreya
Milestone
0.1

Comments

@prestwich
Copy link
Member

prestwich commented May 2, 2024 •
edited
Loading 

          necessary followup work: 
          - decide how to bound the `N::TransactionResponse` type to allow access to the hash

Originally posted by @prestwich in #666 (comment)
@DaniPopes DaniPopes added this to the 0.1-rc.0 milestone Jun 5, 2024
@DaniPopes DaniPopes removed the 0.1-rc.0 label Jun 5, 2024
@gakonst
Copy link
Member

gakonst commented Jun 5, 2024 

trait TransactionResponse {
    fn hash(&self) -> B256
}

similar to Receipt, needs to be implemented for AnyNetwork / EthereumNetwork

https://github.com/alloy-rs/alloy/blob/main/crates/network/src/any/mod.rs#L74
https://github.com/alloy-rs/alloy/blob/main/crates/network/src/ethereum/mod.rs#L34

@yash-atreya yash-atreya mentioned this issue Jun 6, 2024
Merged
3 tasks
@yash-atreya
Copy link
Member

Closed by #835

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@yash-atreya yash-atreya

Labels
None yet
Projects
None yet
Milestone
0.1
Development

No branches or pull requests
4 participants
@prestwich @gakonst @yash-atreya @DaniPopes