[Bug] Full BlockTransactions doesn't offer access to Transaction slice

[sfyll]

Component

rpc

What version of Alloy are you on?

No response

Operating System

None

Describe the bug

Hello sirs.

Wonderful job!

Filling the above. Basically, it's impossible to access the Full transaction field from the BlockTransactionHashesInner object as the only exposed API will collapse a Full transaction into its transaction hash. I would classify this as a bug and not a feature request as it is quite misleading, but happy to be corrected, mostly nomenclature to be honest. It does seem erroneous to download full payloads only to be offered access to the transaction hashes, which are returned in default mode anyways.

Obviously, something might have escaped me from the API, which might deprecate this bug report. Happy to stand corrected!

[prestwich]

maybe i am missing something, but if let BlockTransactions::Full(txns) = block_txns { ... }, or a match block should unblock you.

regardless, it's straightforward to add an as_full(&self) -> Option<&[T]> so i'll do that

[prestwich]

okay it turns out that all the impls here are only for T = Transaction so i may need a trait abstraction for Transaction if i want to make it reusable across networks 🤔

[prestwich]

Pr #666 🤘 will add a convenience function to convert to Option<&[T]> and a convenience iterator over &T

[sfyll]

damn that is very fast ! next one is on me then 🫡