Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use From<Address> for TxKind #651

Merged
merged 2 commits into from
Apr 30, 2024
Merged

use From<Address> for TxKind #651

merged 2 commits into from
Apr 30, 2024

Conversation

tcoratger
Copy link
Contributor

Use From<Address> for TxKind instead of TxKind::Call(value) for a less verbose implementation.

@onbjerg onbjerg added enhancement New feature or request debt Tech debt which needs to be addressed and removed enhancement New feature or request labels Apr 30, 2024
@prestwich prestwich merged commit c3991c3 into alloy-rs:main Apr 30, 2024
18 checks passed
ben186 pushed a commit to ben186/alloy that referenced this pull request Jul 27, 2024
@tcoratger
use From<Address> for TxKind (alloy-rs#651)
d27ce54 
* use From<Address> for TxKind

* fix clippy
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@prestwich prestwich prestwich approved these changes

@onbjerg onbjerg onbjerg approved these changes

@DaniPopes DaniPopes Awaiting requested review from DaniPopes DaniPopes is a code owner

@gakonst gakonst Awaiting requested review from gakonst gakonst is a code owner

@mattsse mattsse Awaiting requested review from mattsse mattsse is a code owner

@Evalir Evalir Awaiting requested review from Evalir

Assignees
No one assigned
Labels
debt Tech debt which needs to be addressed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tcoratger @onbjerg @prestwich