-
Notifications
You must be signed in to change notification settings - Fork 245
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: eth_call builder #645
Conversation
cc @DaniPopes i don't love the amount of lifetime complexity i added to the call with decoder, but it should be invisible to users pretty much all the time i think? |
bdab339
to
3fef547
Compare
Notes on why this level of complexity:
|
okay I have removed the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, nicer than having call_with_overrides
beautiful |
* feature: eth_call via builder pattern * fix: ethcall and ethcallfut in contract * lint: clippy * fix: must_use * fix: must_use again * refactor: borrow hashmap instead of cloning * refactor: use cow and make non-optional * lint: clippy false positive * refactor: rename to eth_call * refactor: remove a lifetime * fix: useless match * fix: poll_running instead of yielding forever * refactor: poll_unpin * doc: example and aliases * doc: add a header to the example
Depends on #644
Motivation
Partially addresses #613
Solution
Provider::call
that allows configuration of theProvider::call
If we like the pattern we can apply it to the other rpc reqs that take
BlockId
as optional paramPR Checklist