Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Refactor] Move Provider into its own module #644

Merged
merged 4 commits into from
Apr 28, 2024
Merged

[Refactor] Move Provider into its own module #644

merged 4 commits into from
Apr 28, 2024

Conversation

prestwich
Copy link
Member

@prestwich prestwich commented Apr 27, 2024 •
edited
Loading

Simplify provider code layout, prep to address #613

Solution

  • Break up provider file into modules
  • move extension APIs into ext module
  • move wallet into provider

PR Checklist

  • Added Tests
  • Added Documentation
  • Breaking changes

@prestwich prestwich added the debt Tech debt which needs to be addressed label Apr 27, 2024
@prestwich prestwich self-assigned this Apr 27, 2024
@prestwich prestwich mentioned this pull request Apr 27, 2024
Merged
3 tasks
onbjerg
onbjerg approved these changes Apr 28, 2024
View reviewed changes
Copy link
Member

@onbjerg onbjerg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

breaks existing imports so next release should be a minor bump, correct?

@prestwich
Copy link
Member Author

oh what breaks? i should fix re-exports

@prestwich
Copy link
Member Author

prestwich commented Apr 28, 2024 •
edited
Loading

Oh the ext module. Yes. Those imports are broken. But we don't currently have a released version so I feel no contract

@prestwich prestwich merged commit 4203d98 into main Apr 28, 2024
18 checks passed
@prestwich prestwich deleted the prestwich/provider-module branch April 28, 2024 12:31
ben186 pushed a commit to ben186/alloy that referenced this pull request Jul 27, 2024
@prestwich
[Refactor] Move Provider into its own module (alloy-rs#644)
a822ba2 
* refactor: provider into module

* fix: move sendable to module

* refactor: move extension apis into ext module

* refactor: wallet into provider
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@onbjerg onbjerg onbjerg approved these changes

@DaniPopes DaniPopes Awaiting requested review from DaniPopes DaniPopes is a code owner

@gakonst gakonst Awaiting requested review from gakonst gakonst is a code owner

@mattsse mattsse Awaiting requested review from mattsse mattsse is a code owner

@Evalir Evalir Awaiting requested review from Evalir

Assignees

@prestwich prestwich

Labels
debt Tech debt which needs to be addressed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@prestwich @onbjerg