feat: add extra_fields to ChainConfig #631
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fgimenez
requested review from
DaniPopes,
gakonst,
mattsse,
onbjerg,
prestwich and
Evalir
as code owners
mattsse
requested changes
Apr 25, 2024
Co-authored-by: Matthias Seitz <[email protected]>
onbjerg
approved these changes
Apr 25, 2024
makes sense, done |
mattsse
approved these changes
Apr 25, 2024
ben186
pushed a commit
to ben186/alloy
that referenced
this pull request
Jul 27, 2024
* feat: add extra_fields to ChainConfig * add test * String from alloc * add serde_json to deps * use serde_json::Value instead of reexporting from serde crate Co-authored-by: Matthias Seitz <[email protected]> * remove extra line * remove json_value import --------- Co-authored-by: Matthias Seitz <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Towards paradigmxyz/reth#7702
Currently fields specific to chains different from mainnet Ethereum (like those related to OP forks) are not being deserialized into ChainConfig.
Solution
Adds an
extra_fieldsfield to ChainConfig to gather the additional chain-specific information without polluting the top-level object.PR Checklist