docs: add required softwares to run tests in Contributing.md #627
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I was unable to run the tests for alloy (Cf alloy-rs#626) it was due to missing the `geth` and `Anvil` software. I have added the requirements in the `Contributing.md` file so that other developers can directly see that they are needed. I specified `geth v1.13.x` because testsuite doesn't work for now on latest geth version: `geth v1.14.0` But the testsuite may work in future geth release, I am not sure that fixing the version to `1.13.x` is a good idea. (Anyway when we run `cargo test` with `geth v1.14.0` it tells us to use `geth v1.13.x)
NicolasWent
requested review from
DaniPopes,
gakonst,
mattsse,
onbjerg,
prestwich and
Evalir
as code owners
|
It's an error if alloy doesn't work with the latest geth version, so please remove the 1.13.x |
onbjerg
changed the title
onbjerg
approved these changes
Apr 24, 2024
ben186
pushed a commit
to ben186/alloy
that referenced
this pull request
Jul 27, 2024
…s#627) * Add required softwares to run tests in Contributing.md I was unable to run the tests for alloy (Cf alloy-rs#626) it was due to missing the `geth` and `Anvil` software. I have added the requirements in the `Contributing.md` file so that other developers can directly see that they are needed. I specified `geth v1.13.x` because testsuite doesn't work for now on latest geth version: `geth v1.14.0` But the testsuite may work in future geth release, I am not sure that fixing the version to `1.13.x` is a good idea. (Anyway when we run `cargo test` with `geth v1.14.0` it tells us to use `geth v1.13.x) * [Contributing.md] Changed the fixed version on geth * Update CONTRIBUTING.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
I was unable to run the tests for alloy (Cf #626) it was due to missing the
gethandAnvilsoftware.Solution
I have added the requirements in the
Contributing.mdfile so that other developers can directly see that they are needed.I specified
geth v1.13.xbecause testsuite doesn't work for now on latest geth version:geth v1.14.0But the testsuite may work in future geth release, I am not sure that fixing the version to
1.13.xis a good idea because we will have to change it manually every time we upgrade. And anyways, when we runcargo testwithgeth v1.14.0it tells us to use `geth v1.13.xPR Checklist
Only Text modification no code change