Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Easier review for Callbuilder implement partial eip 1559 #625

Merged
merged 1 commit into from
Apr 25, 2024

Conversation

NicolasWent
Copy link
Contributor

Old PR: #488

This PR contains only the file that I have changed, I made a new PR because on the old one I have rebased all of main's commits, which makes the old one hard to review

Text from previous PR:

Motivation

Implements #487

Solution

Implemented a way to modify the fields:

  • max_fee_per_gas
  • max_priority_fee_per_gas
  • access_list

PR Checklist

  • Added Tests
    • Testing if modifications are correctly taken in account by the inner transaction object
    • Tested sending a transaction with specific max_priority_fee_per_gas and max_fee_per_gas
  • Added Documentation
  • Breaking changes => changes shouldn't break anything

Copy link
Member

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mattsse mattsse merged commit 4d77029 into alloy-rs:main Apr 25, 2024
18 checks passed
ben186 pushed a commit to ben186/alloy that referenced this pull request Jul 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants