Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: don't serialize nulls in tx request #621

Merged
merged 1 commit into from
Apr 23, 2024
Merged

fix: don't serialize nulls in tx request #621

merged 1 commit into from
Apr 23, 2024

Conversation

DaniPopes
Copy link
Member

@DaniPopes DaniPopes changed the title fix: serialization of None fields in tx request fix: don't serialize nulls in tx request Apr 23, 2024
onbjerg
onbjerg approved these changes Apr 23, 2024
View reviewed changes
Copy link
Member

@onbjerg onbjerg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reasonable

@onbjerg onbjerg added bug Something isn't working debt Tech debt which needs to be addressed labels Apr 23, 2024
@DaniPopes DaniPopes merged commit 25239e3 into main Apr 23, 2024
18 checks passed
@DaniPopes DaniPopes deleted the dani/ser-txrequest branch April 23, 2024 23:47
ben186 pushed a commit to ben186/alloy that referenced this pull request Jul 27, 2024
@DaniPopes
fix: don't serialize nulls in tx request (alloy-rs#621)
2af513d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@onbjerg onbjerg onbjerg approved these changes

@gakonst gakonst Awaiting requested review from gakonst gakonst is a code owner

@mattsse mattsse Awaiting requested review from mattsse mattsse is a code owner

@prestwich prestwich Awaiting requested review from prestwich

@Evalir Evalir Awaiting requested review from Evalir

Assignees
No one assigned
Labels
bug Something isn't working debt Tech debt which needs to be addressed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

forge create sets eth_estimateGas's type field to null, which does not work with a Besu node
2 participants
@DaniPopes @onbjerg