Make additional TxReceipt impls generic over T #617
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
developeruche
requested review from
DaniPopes,
gakonst,
mattsse,
onbjerg,
prestwich and
Evalir
as code owners
gakonst
reviewed
Apr 23, 2024
Comment on lines
+46
to
+47
| where | ||
| T: Borrow<Log>, |
There was a problem hiding this comment.
do we want this? thought we may want to be generic over this and do T = Log perhaps
There was a problem hiding this comment.
pub fn bloom_slow(&self) -> Bloom {
self.logs.iter().map(Borrow::borrow).collect()
}We made use of this here;
We might have to change this implementation, thou Log works for most of the use-cases I can think of now.
There was a problem hiding this comment.
it's a bit more complicated and we will need more work here. Because Log is actually Log<T = LogData> we want to be able to implement generically across a wide variety of types, and may need to introduce a trait Log in order to do it
For now, this is an improvement over the existing state of things so we might as well
DaniPopes
approved these changes
Apr 23, 2024
Evalir
approved these changes
Apr 24, 2024
onbjerg
approved these changes
Apr 24, 2024
ben186
pushed a commit
to ben186/alloy
that referenced
this pull request
Jul 27, 2024
* introduced Receipt trait * fmt * mod: switch to TxReceipt trait * fmt * impl Receipt for ReceiptEnvelope * mod: removed todo() * resovling comments and CI * mod: impl TxReceipt trait
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Closes #606
Solution
Just made the impl and extended the trait bound on
ReceiptWithBloomPR Checklist