fix: continue reading ipc on data error #605
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattsse
requested review from
DaniPopes,
gakonst,
onbjerg,
prestwich and
Evalir
as code owners
prestwich
approved these changes
Apr 23, 2024
DaniPopes
reviewed
Apr 23, 2024
| // trigger pending read | ||
| .wait(std::time::Duration::from_millis(1)) | ||
| // complete object | ||
| .read(vec![b"a"[0]; CAPACITY].as_ref()) |
Closed
|
Is there a reason for setting CAPACITY 4096? Lots of RPC response can exceed this. |
|
this is the initial, pre allocated capacity |
|
Yeah but a partial response will hit if this.buf.len() > CAPACITY {
// buffer is full, we can't decode any more
error!("IPC response too large to decode");
return Ready(None);
} |
|
oh right, this is wrong of course -.- |
ben186
pushed a commit
to ben186/alloy
that referenced
this pull request
Jul 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the json stream deserializer has issues with partial objects.
this continues the stream on data errors as long as the internal buffer does not exceed the configured capacity