Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add builder methods #591

Merged
merged 5 commits into from
Apr 22, 2024

Conversation

EmperorOrokuSaki
Copy link
Contributor

Motivation

Issue #583

Solution

Implement builder methods for all fields

PR Checklist

  • Added Tests
  • Added Documentation
  • Breaking changes

Copy link
Member

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ty,
some nits

crates/rpc-types-trace/src/filter.rs Outdated Show resolved Hide resolved
crates/rpc-types-trace/src/filter.rs Show resolved Hide resolved
crates/rpc-types-trace/src/geth/mod.rs Outdated Show resolved Hide resolved
@prestwich prestwich merged commit d8584f5 into alloy-rs:main Apr 22, 2024
18 checks passed
ben186 pushed a commit to ben186/alloy that referenced this pull request Jul 27, 2024
* feat: add trace filter builder methods

* feat: add builder methods for GethDebugTracingCallOptions

* refactor: rename methods to have the prefix "with"

* refactor: rename and ownership changes.

* fix: clippy ci
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants