Temp get_uncle fix #589
Merged
Temp get_uncle fix #589
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yash-atreya
requested review from
DaniPopes,
gakonst,
mattsse,
onbjerg,
prestwich and
Evalir
as code owners
DaniPopes
reviewed
Apr 19, 2024
DaniPopes
approved these changes
Apr 19, 2024
ben186
pushed a commit
to ben186/alloy
that referenced
this pull request
Jul 27, 2024
* possible fix * temp-fix: rollback to U64 * fix: convert in fn
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Passing the primitive type for the
idxleads to the following error:server returned an error response: error code -32602: invalid argument 1: json: cannot unmarshal non-string into Go value of type hexutil.Uintin the anvil integration test: https://github.com/yash-atreya/foundry/blob/cfeffd5f5cd7c4225ddd3f35ab1c2618648200db/crates/anvil/tests/it/fork.rs#L852
Solution
Temp fix is to rollback to non-primitive type
U64.PR Checklist