Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(provider/debug): arg type in debug_trace_call #585

Merged
merged 1 commit into from
Apr 19, 2024
Merged

fix(provider/debug): arg type in debug_trace_call #585

merged 1 commit into from
Apr 19, 2024

Conversation

yash-atreya
Copy link
Member

@yash-atreya yash-atreya commented Apr 19, 2024 •
edited by mattsse
Loading

Motivation

debug_trace_call was taking the GethDebugTracingOptions as trace_options whereas it should be GethDebugTracingCallOptions

closes #579

Solution

Replace with GethDebugTracingCallOptions

PR Checklist

  • Added Tests
  • Added Documentation
  • Breaking changes

@mattsse mattsse merged commit c7a51e9 into alloy-rs:main Apr 19, 2024
18 checks passed
ben186 pushed a commit to ben186/alloy that referenced this pull request Jul 27, 2024
@yash-atreya
fix(provider/debug): arg type in debug_trace_call (alloy-rs#585)
f47df64
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattsse mattsse mattsse approved these changes

@DaniPopes DaniPopes Awaiting requested review from DaniPopes DaniPopes is a code owner

@gakonst gakonst Awaiting requested review from gakonst gakonst is a code owner

@onbjerg onbjerg Awaiting requested review from onbjerg onbjerg is a code owner

@prestwich prestwich Awaiting requested review from prestwich

@Evalir Evalir Awaiting requested review from Evalir

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug] debug_trace_call and debug_trace_call_many invalid parameter
2 participants
@yash-atreya @mattsse