Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should these derive the rlp encodable macro? #57

Closed
0xJepsen opened this issue Nov 30, 2023 · 2 comments
Closed

Should these derive the rlp encodable macro? #57

0xJepsen opened this issue Nov 30, 2023 · 2 comments
Labels
question Further information is requested

Comments

@0xJepsen
Copy link

pub enum TypedTransactionRequest {

if not how should i serialize my transaction to be be signed. Working on something like thi

       let mut payload = Self::path_to_bytes(&self.derivation);

        // need to figure out how to encode the alloy TypedTransactionRequest into a Vec<u8>
        payload.extend_from_slice(tx.encode().as_slice());

        let mut signature = self.sign_payload(Instruction::Sign, &payload).await?;
@prestwich
Copy link
Member

prestwich commented Dec 1, 2023

right now this crate has RPC type, which is actually a superset of the Transaction type that gets RLP encoded. we're still planning how to make this distinction smooth. I am skeptical of implementing rlp encodabe/decodable for types with more props than the actually encoding will represent

related conversation in #50

@prestwich prestwich added the question Further information is requested label Dec 1, 2023
@prestwich
Copy link
Member

closing this as the answer is now clearly no. this is superseded by #83 and #78

@prestwich prestwich closed this as not planned Won't fix, can't repro, duplicate, stale Dec 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants