feat: add rpc-types-anvil #526
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattsse
requested review from
DaniPopes,
gakonst,
onbjerg,
prestwich and
Evalir
as code owners
mattsse
force-pushed
the
matt/add-rpc-types-anvil
branch
from
2cae55d
to
459139a
Compare
onbjerg
approved these changes
Apr 13, 2024
crates/rpc-types-anvil/src/lib.rs
Outdated
| clippy::missing_const_for_fn, | ||
| rustdoc::all | ||
| )] | ||
| #![allow(missing_docs)] |
There was a problem hiding this comment.
add follow up issue to remove this, we want docs, but don't want to block this PR on it since it's a niche-ish crate and it is blocking other work streams
Co-authored-by: Oliver Nordbjerg <[email protected]>
Co-authored-by: Oliver Nordbjerg <[email protected]>
ben186
pushed a commit
to ben186/alloy
that referenced
this pull request
Jul 27, 2024
* feat: add rpc-types-anvil * Update crates/rpc-types-anvil/README.md Co-authored-by: Oliver Nordbjerg <[email protected]> * Update crates/rpc-types-anvil/src/lib.rs Co-authored-by: Oliver Nordbjerg <[email protected]> * add docs --------- Co-authored-by: Oliver Nordbjerg <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
adds a crate for rpc types used by anvil
there are only a handful types, it's easier to maintain these in this workspace, and we could also an anvil provider trait for specific dev functions,
and this would also make it possible to define server API traits:
paradigmxyz/reth#7495