Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: correctly parse IPC sockets in builtin connections #522

Merged
merged 1 commit into from
Apr 12, 2024
Merged

fix: correctly parse IPC sockets in builtin connections #522

merged 1 commit into from
Apr 12, 2024

Conversation

DaniPopes
Copy link
Member

IPC sockets return false for all is_* metadata queries.

mattsse
mattsse approved these changes Apr 12, 2024
View reviewed changes
Copy link
Member

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice, lgtm!

@DaniPopes DaniPopes merged commit 1f6375a into main Apr 12, 2024
18 checks passed
@DaniPopes DaniPopes deleted the dani/fix-ipc-parsing branch April 12, 2024 20:09
ben186 pushed a commit to ben186/alloy that referenced this pull request Jul 27, 2024
@DaniPopes
fix: correctly parse IPC sockets in builtin connections (alloy-rs#522)
22bb037
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattsse mattsse mattsse approved these changes

@gakonst gakonst Awaiting requested review from gakonst gakonst is a code owner

@onbjerg onbjerg Awaiting requested review from onbjerg onbjerg is a code owner

@prestwich prestwich Awaiting requested review from prestwich

@Evalir Evalir Awaiting requested review from Evalir

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DaniPopes @mattsse