Feat: allow multiple signing credentials in NetworkSigner #515
Conversation
prestwich
added
enhancement
prestwich
requested review from
DaniPopes,
gakonst,
mattsse,
onbjerg and
Evalir
as code owners
| /// Asynchronously sign an unsigned transaction, with a specified | ||
| /// credential. | ||
| async fn sign_transaction_from( | ||
| &self, | ||
| sender: Option<Address>, | ||
| tx: N::UnsignedTx, | ||
| ) -> alloy_signer::Result<N::TxEnvelope>; |
There was a problem hiding this comment.
this makes sense to me and is convenient to have,
it should be trivial for any, non-multiplex signers to implement by ensuring the default signer is Some(sender)
There was a problem hiding this comment.
doing a slight cleanup here as i wrote this function signature before i added the default signer
There was a problem hiding this comment.
removed the Option because we can rely on the caller to call default_signer
Added that, and a method to get an iterator of addresses that we can sign with |
| @@ -148,7 +148,7 @@ impl TransactionBuilder<Ethereum> for TransactionRequest { | |||
| self, | |||
| signer: &S, | |||
| ) -> BuilderResult<<Ethereum as Network>::TxEnvelope> { | |||
| Ok(signer.sign_transaction(self.build_unsigned()?).await?) | |||
| Ok(signer.sign_request(self).await?) | |||
There was a problem hiding this comment.
these were dropping the from field during the build process regardless of whether it were set in the first place 😓
|
What does "Preswitch/signer multiplex" mean? 😄 |
|
branch name 😅 |
prestwich
changed the title
* feature: signer multiplexing * fix: register default on instantiation * docs: fixup * fix: clippy * fix: sign_request * fix: clippy * feat: is_signer_for and signers * fix: signer returns copied addresses * fix: remove unnecessary option
Resolves signer filler not setting from and failing to sign
Motivation
Unblock foundry dev
Solution
NetworkSigner<N>is now expected to contain a store of credentials, by address.NetworkSigner<N>now selects credentials based on requestfromfieldNetworkSigner<N>allows user-specified sender when signingPR Checklist