[Feature] Change all Option<BlockId> to BlockId on methods in the Provider

[zerosnacks]

Component

provider, pubsub

Describe the feature you would like

get_code_at and get_uncle on the Provider currently require the user to define the tag whereas others allow for defining tag as None, where None means defaulting to Latest.

alloy/crates/provider/src/provider.rs

Lines 768 to 771 in 7629f79

	/// Gets the bytecode located at the corresponding [Address].
	async fn get_code_at(&self, address: Address, tag: BlockId) -> TransportResult<Bytes> {
	self.client().request("eth_getCode", (address, tag)).await
	}

alloy/crates/provider/src/provider.rs

Lines 826 to 836 in 7629f79

	/// Gets an uncle block through the tag [BlockId] and index [U64].
	async fn get_uncle(&self, tag: BlockId, idx: U64) -> TransportResult<Option<Block>> {
	match tag {
	BlockId::Hash(hash) => {
	self.client().request("eth_getUncleByBlockHashAndIndex", (hash, idx)).await
	}
	BlockId::Number(number) => {
	self.client().request("eth_getUncleByBlockNumberAndIndex", (number, idx)).await
	}
	}
	}

Whereas other methods allow for defining tag as None,

alloy/crates/provider/src/provider.rs

Lines 627 to 639 in 7629f79

	/// Gets the transaction count (AKA "nonce") of the corresponding address.
	#[doc(alias = "get_nonce")]
	#[doc(alias = "get_account_nonce")]
	async fn get_transaction_count(
	&self,
	address: Address,
	tag: Option<BlockId>,
	) -> TransportResult<u64> {
	self.client()
	.request("eth_getTransactionCount", (address, tag.unwrap_or_default()))
	.await
	.map(|count: U64| count.to::<u64>())
	}

Where automatically defaulting means Latest:

alloy/crates/rpc-types/src/eth/block.rs

Lines 719 to 723 in 987b393

	impl Default for BlockId {
	fn default() -> Self {
	BlockId::Number(BlockNumberOrTag::Latest)
	}
	}

Based on feedback from @mattsse on the PR of @EmperorOrokuSaki it was decided to instead of making get_code_at and get_uncle have Option<BlockId> to change all other methods to use BlockId (not optional).

Additional context

No response

[EmperorOrokuSaki]

I'll work on this.

[EmperorOrokuSaki]

Hey, update on this. The direction is going to be the removal of all Option params and making them required in provider methods. This ensures consistency with the JSON RPC specification.

[zerosnacks]

Hey, update on this. The direction is going to be the removal of all Option params and making them required in provider methods. This ensures consistency with the JSON RPC specification.

Thanks! I'll update the description and title

[EmperorOrokuSaki]

Can we close this issue? The PR was merged.