feat(rpc): trace requests and responses #498
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DaniPopes
requested review from
gakonst,
mattsse,
onbjerg,
prestwich and
Evalir
as code owners
DaniPopes
force-pushed
the
dani/trace-rpc-io
branch
from
2866906 to
6694c7d
Compare
mattsse
approved these changes
Apr 10, 2024
|
|
||
| let request = request.take().expect("no request"); | ||
| debug!(method=%request.meta.method, id=%request.meta.id, "sending request"); |
There was a problem hiding this comment.
should we log the entire request object?
There was a problem hiding this comment.
Yes I think so, added a trace! with ?request and params type name
DaniPopes
force-pushed
the
dani/trace-rpc-io
branch
from
6694c7d to
db37991
Compare
klkvr
pushed a commit
to klkvr/alloy
that referenced
this pull request
Apr 11, 2024
ben186
pushed a commit
to ben186/alloy
that referenced
this pull request
Jul 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is currently no way of knowing what raw data we are sending and receiving.
Add
trace!calls around theRpcClientfuture for this, as well as a simplerdebug!for just the method and ID, as the raw data could be very verbose.Running
test_send_txwithalloy=debug, I think this verbosity is fair for debug: