Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: allow empty to field in can_build #489

Merged
merged 2 commits into from
Apr 9, 2024

Conversation

klkvr
Copy link
Member

@klkvr klkvr commented Apr 9, 2024

Motivation

to is required to be Some only for EIP-4844 txses

Solution

PR Checklist

  • Added Tests
  • Added Documentation
  • Breaking changes

Copy link
Member

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm,

only 4844 mandates a to field

@mattsse mattsse merged commit 5f74d4e into alloy-rs:main Apr 9, 2024
18 checks passed
klkvr added a commit to klkvr/alloy that referenced this pull request Apr 11, 2024
ben186 pushed a commit to ben186/alloy that referenced this pull request Jul 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants