-
Notifications
You must be signed in to change notification settings - Fork 245
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
enable default-tls for alloy-provider/reqwest feature #483
Conversation
crates/provider/Cargo.toml
Outdated
@@ -55,6 +55,7 @@ reqwest = [ | |||
"dep:url", | |||
"dep:alloy-transport-http", | |||
"alloy-rpc-client/reqwest", | |||
"alloy-transport-http/reqwest-default-tls", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this will enable native tls, openssl by default now?
I want to avoid this because then this will now always enable default-tls for reqwest
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
in order to leave this up to the user we'd need to duplicate the features, I assume:
alloy/crates/transport-http/Cargo.toml
Lines 40 to 42 in 6cc0af7
reqwest-default-tls = ["reqwest?/default-tls"] | |
reqwest-native-tls = ["reqwest?/native-tls"] | |
reqwest-rustls-tls = ["reqwest?/rustls-tls"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
so we should expose those in alloy-provider but enable default-tls by default?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
so we should expose those in alloy-provider
yes
but enable default-tls by default?
since reqwest enables this by default as well, I think that'd be reasonable.
but tls must be a separate feature, so default is = ["reqwest", "reqwest-default-ts"]
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
pending @mattsse
* enable default-tls for alloy-provider/reqwest feature * update features
* enable default-tls for alloy-provider/reqwest feature * update features
Motivation
Currently it's not possible to connect to https endpoint via
on_http
with default feature setSolution
PR Checklist