Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Debt] Clean up serde helpers and remove redundant code #479

Closed
4 tasks done
prestwich opened this issue Apr 7, 2024 · 0 comments · Fixed by #624
Closed
4 tasks done

[Debt] Clean up serde helpers and remove redundant code #479

prestwich opened this issue Apr 7, 2024 · 0 comments · Fixed by #624

Comments

@prestwich
Copy link
Member

prestwich commented Apr 7, 2024

With the numeric type audit, and #478, we've been maintaining code that is redundant given the switch to ruint from parity-types

this is also followup to #443

  • delete U64HexOrDecimal newtype wrapper as redundant
  • delete _or_decimal variants of helper modules as redundant
  • check other helpers for redundancy
  • rename helper modules to u**_via_ruint to make behavior clearer

on consideration, we might want to rename the helpers something like u64_via_ruint to clarify behavior

Originally posted by @prestwich in #478 (comment)

@yash-atreya yash-atreya mentioned this issue Apr 8, 2024
3 tasks
@prestwich prestwich changed the title [Debt] Clean up see helpers and remove redundant code [Debt] Clean up serde helpers and remove redundant code Apr 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant