configure polling interval #437
Conversation
yash-atreya
changed the title
|
This wouldn't work. Making changes |
crates/rpc-client/src/client.rs
Outdated
| inner.set_poll_interval(poll_interval); | ||
| self | ||
| } else { | ||
| todo!("TBD: Value is already shared. Cannot be mutated"); |
There was a problem hiding this comment.
we could have the poll interval be an atomic number of seconds instead of a duration?
There was a problem hiding this comment.
Even if we have it as an atomic number, we would still need to use Arc::get_mut since RpcClientInner is wrapped in Arc.
There was a problem hiding this comment.
atomics don't require a &mut reference to modify
yash-atreya
requested review from
DaniPopes,
gakonst,
mattsse,
onbjerg and
Evalir
as code owners
| /// Note: Sets the poll interval to 250ms for local transports and 7s for remote transports by | ||
| /// default. |
There was a problem hiding this comment.
we could tweak this based in the chain, because 7s exceeds avg blocktime of a lot of chains.
the alloy_chains::Chain has a function for this.
so we could integrate this in eth_chainId call for example and track whether we've already set the poll_interval based on chain_id
| transport: t, | ||
| is_local, | ||
| id: AtomicU64::new(0), | ||
| poll_interval: if is_local { AtomicU64::new(250) } else { AtomicU64::new(7000) }, |
There was a problem hiding this comment.
i'd make this 2s given the rise of L2s with faster blocktimes
* feat(rpc-client): add set_poll_interval method * fix: using with_poll_interval in RpcClient * use AtomicU64 for poll interval * PollerBuilder nits * fix test * store Ordering::Relaxed
Motivation
#290
Solution
Add methods to
RpcClientandRootProviderto configure the polling interval.PR Checklist